Re: [caudium-devel] FastCGI update

[Bill Welliver <hww3 AT riverweb.com>]

What do the end users experience when this error appears in the
logs? Do they get truncated responses from the server? Perhaps this patch
will make things better... (I've not actually tested it, aside from
verifying that the code compiles.


Index: cgi.pike
===================================================================
RCS file: /cvs/caudium/caudium/server/modules/scripting/cgi.pike,v
retrieving revision 1.60
diff -r1.60 cgi.pike
309,310c309,311
<       report_error("CGI:Wrapper::destroy() killed while there was still
data in the buffer\n");
<       DWERROR(sprintf("CGI:Wrapper:destroy() buffer:\n%s\n", buffer));
---
>       report_error("CGI:Wrapper::destroy() killed while there was still
data in the buffer; reverting to sendfile()\n");
>       DWERROR(sprintf("CGI:Wrapper:destroy(), sending buffer via
sendfile():\n%s\n", buffer));
>       Stdio.sendfile(0, Stdio.FakeFile(buffer), -1, -1, 0, tofd, 
> really_close);
312,313c313,320
<
<
---
>     else
>     {
>        really_close();
>     }
>   }
>
>   void really_close(void |mixed ... args)
>   {


> While using CGI, i have sometimes the following debug log:
>
> ----8<----8<----8<----8<----
> CGI:Wrapper::destroy() killed while there was still data in the buffer
> ---->8---->8---->8---->8----