[caudium-devel] Re: [caudium-commits] CVS: caudium/src/cmods/_Caudium caudium.c,1.144.2.13,1.144.2.14

[Bertrand LUPART <bertrand.lupart AT linkeo.com>]

> Still, the skey in the empty variables multiset isn't url_decoded.
>
>
> Index: caudium.c
> ===================================================================
> RCS file: /cvs/caudium/caudium/src/cmods/_Caudium/caudium.c,v
> retrieving revision 1.144.2.13
> retrieving revision 1.144.2.14
> diff -u -r1.144.2.13 -r1.144.2.14
> --- caudium.c   19 Sep 2006 18:35:53 -0000      1.144.2.13
> +++ caudium.c   22 Feb 2007 09:13:03 -0000      1.144.2.14
> @@ -18,11 +18,11 @@
>   *
>   */
>  /*
> - * $Id: caudium.c,v 1.144.2.13 2006/09/19 18:35:53 kiwi Exp $
> + * $Id: caudium.c,v 1.144.2.14 2007/02/22 09:13:03 bertrand Exp $
>   */
>
>  #include "global.h"
> -RCSID("$Id: caudium.c,v 1.144.2.13 2006/09/19 18:35:53 kiwi Exp $");
> +RCSID("$Id: caudium.c,v 1.144.2.14 2007/02/22 09:13:03 bertrand  
> Exp $");
>  #include "caudium_util.h"
>  #include "caudium_machine.h"
>  #include "entparse.h"
> @@ -87,7 +87,7 @@
>  /*
>  **! file: Caudium/caudium.c
>  **!  Caudium specific classes and functions.
> -**! cvs_version: $Id: caudium.c,v 1.144.2.13 2006/09/19 18:35:53  
> kiwi Exp $
> +**! cvs_version: $Id: caudium.c,v 1.144.2.14 2007/02/22 09:13:03  
> bertrand Exp $
>  */
>
>  /*
> @@ -1066,14 +1066,14 @@
>
>            if (!valulen) {
>              /* valueless, add the name to the multiset */
> -            sval.type = T_STRING;
> -            sval.u.string = make_shared_binary_string(name, namelen);
> -            if (!sval.u.string)
> +            skey.type = T_STRING;

What's the goal of the following line?

> +            skey.u.string = make_shared_binary_string(name, namelen);

If i remove it, the empty vars variables names are perfectly url  
decoded again, and everything seems to work perfectly.


> +            if (!skey.u.string)
>                Pike_error("Out of memory.\n");
> -            multiset_insert(emptyvars, &sval);
> +            multiset_insert(emptyvars, &skey);
>
>              free_svalue(&skey);
> -            free_svalue(&sval);
> +//            free_svalue(&sval);
>
>              name = ptr + 1;
>              equal = NULL;

--
Bertrand LUPART
                  Linkeo.com | http://www.linkeo.com/
           +33 1 72 71 71 84 | 17, rue de la Banque - F75002 Paris
        http://www.linkeo.com/signatures/bertrand-lupart/